Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying Korean Translation #1547

Merged
merged 4 commits into from
Jan 29, 2023
Merged

Conversation

qlife1146
Copy link
Contributor

I added untranslated parts, corrected typos, and translated them more intuitively.

@ImprovedTube
Copy link
Member

Thank you @qlife1146 !!

Copy link
Contributor Author

@qlife1146 qlife1146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has been modified a lot because of prettier. I'm sorry.

@ImprovedTube
Copy link
Member

ImprovedTube commented Jan 26, 2023

Thank you so much! @qlife1146

  • Korean translation: hi! @msc9533 @LYHyoung have look maybe?😳 (we are most popular in Korea out of all countries)

  • Youtube API: [youtube API independence] (+Required update:Videos Count & Age) #1452 these are our options yet.

  • Code-beautification: " vs ' : How did you do it? Shouldn't it be consistent for the whole project? ( could do this for the whole project. Also considering to replace " and \' within the same strings...).

Thanks :)

@qlife1146
Copy link
Contributor Author

qlife1146 commented Jan 26, 2023

  • ode-beautification: " vs ' : How did you do it? Shouldn't it be consistent for the whole project? ( could do this for the whole project. Also considering to replace " and \

As for Code-beautification, I use prettier, which is the extension of vscode, and all of the ""s have been changed.

@ImprovedTube ImprovedTube requested a review from LYHyoung January 29, 2023 02:25
@ImprovedTube ImprovedTube merged commit 0030c6f into code-charity:master Jan 29, 2023
@ImprovedTube
Copy link
Member

Thank you!! :)

prettier

@prettier https://github.com/prettier/prettier

ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants