Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time remaining to have the option to use playback speed #1442

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

BitbenderM
Copy link
Contributor

@BitbenderM BitbenderM commented Oct 3, 2022

Update of extension to have an option that when set will update the time remaining with reference to the playback speed. Locales are updated only with english version, should be updated by someone able to translate when possible.

Issue #1224

Update of extension to have an option that when set will update the time remaining with reference to the playback speed.

Issue code-charity#1224
@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 4, 2022

Yay! Welcome @BitbenderM and thank you so much!
how did you find the Repo? :)
(did you used the .py script to add the language items? 👍)

i thought this should be automatically included with "show video duration remaining"
(thats why i labeled it "revision / completition")

(so just time.setSeconds(rTime) time.setSeconds(rTime/this.elements.video.playbackRate); )

(but of course both make sense. Everything can be a switch. Then we just need to sort them by priority some time and secondary ones smaller/indented/nested..)

@BitbenderM
Copy link
Contributor Author

BitbenderM commented Oct 4, 2022

Hi ImprovedYoutube

The person who raised issue #1224 actually is my friend and asked if I'd be able to do something like this. Not much exp in js but seemed easy enough.

I didn't actually use the py script, didn't realise it lol. I just did a replace in all files where it would be alphabetically.

We figured it would be better to have the switch incase people were more familiar with the old style and didn't really care about the true time remaining.

@hboyd2003
Copy link
Contributor

hboyd2003 commented Oct 4, 2022

Locales are updated only with english version, should be updated by someone able to translate when possible.

I am working on making this easier since we are low on contributors currently

@ImprovedTube
Copy link
Member

@BitbenderM please come back or ask your friend for more wishes :D

locales

@hboyd2003 ohh you are at the .py scripts? 🥰💕

BTW the UI names text: 'durationWithSpeed' are the international default, that all uses will see, when their langauges file is not complete. (including english)... - so we (all extension developers) can gradually shift to use white spaces there or at best functional emojis (like🚫🔒)(=international)

@ImprovedTube ImprovedTube merged commit b3346fa into code-charity:master Oct 5, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 5, 2022

people were more familiar with the old style

yes👍 @BitbenderM besides why would they be sentimental about us fixing this calculation while the other values stay in place🤔
The ultimate solution is:

  • 1)Only showing the switch when the parent feature is enabled - so not a million people see it who dont need/want.

    • 2)enabling the new child-feature by default, if the parent-feature is enabled. Or at least/especially if speed is permanently raised since (they crave effiency. Maybe they are 25 000 but busy so few of them notice the new switch soon)
      (while others who just sporadically change speed might not immediately get it but smart is nice? :)
  • moreover: Remaining time (Including this addition) deserves popularity, since it could harmlessly be enabled for ALL our users (if we are ready to get some feedback and find the perfect equilibrium. ( besides this can include code-perfectionism / estimating for once how much/little electricity will collectively be consumed by running millions of times per day)

#1448 :D

ImprovedTube added a commit that referenced this pull request Oct 16, 2022
Update time remaining to have the option to use playback speed
ImprovedTube added a commit that referenced this pull request Oct 18, 2022
Update time remaining to have the option to use playback speed
ImprovedTube added a commit that referenced this pull request Oct 18, 2022
Update time remaining to have the option to use playback speed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants