-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share, Clip, Thanks and Save buttons unaffected when selecting Icon Only #2171
Comments
Hey, I would like to work on this. |
Hi & thanks! @NoaSkyrider @ADTmux
optional JS: youtube/js&css/web-accessible/www.youtube.com/appearance.js Lines 425 to 437 in 04a604b
called at page-load or by our mutation observer: youtube/js&css/web-accessible/functions.js Lines 135 to 138 in 04a604b
|
Fix:
Consider commenting out: functions.js#L135-L138 (,which enables appearance.js#L425-L437(, which enabled details.css/#L80-L88)) (since we have many users, so the electrons add up a bit) as this is just a backup solution by now (thanks again @dodieboy!), while the icon's SVG pathes might stay similar enough (and ultimately we could automatically keep a list of the SVG pathes up to date, as an online file and include that in the extension without waiting for approval as for JS updates) |
Hey @ImprovedTube , I'm curious to know why that works. |
hi! @ADTmux and to make more sure, if the old CSS still works or still possibly is required for some setups from youtube, we can set some youtube config manually in the browser console:
btw, there are 850+ such values, which will help with several feature requests or bug reports so we should make UI and documentation for them: |
I'm afraid I don't know what I'm supposed to access to apply this fix. Apologies, I'm new to this. |
Fix will be published ublock:
|
As I said, the Share, Clip, Thanks and Save buttons are unaffected when selecting Icon Only. The Download, Like and Dislike buttons etc. are affect as normal.
With Icon Only disabled:
With Icon Only enabled:
I do use a few other extensions for YouTube, including Enhancer for YouTuber and Tweaks for YouTube, but disabling them has no effect.
Having this feature work would be preferable.
The text was updated successfully, but these errors were encountered: