Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-05 MitigationConfirmed #28

Open
c4-bot-6 opened this issue Mar 3, 2024 · 1 comment
Open

H-05 MitigationConfirmed #28

c4-bot-6 opened this issue Mar 3, 2024 · 1 comment
Labels
mitigation-confirmed MR-H-05 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-6
Copy link
Contributor

c4-bot-6 commented Mar 3, 2024

Lines of code

Vulnerability details

Summary

H-05 talks about evading liquidation attempt due to colldownExpiration related manipulation possible.
The liquidateUser() functionality used to be present in the CollateralAndLiquidity.sol file.

Mitigation

Various changes have been done in this commit as a result of which the above file and functionality does not exist anymore:

The stablecoin framework has been removed: /stablecoin, /price_feed, WBTC/WETH collateral, PriceAggregator, price feeds and USDS.

Hence this is no more applicable.

Conclusion

Can be considered as fixed.
c4-bot-2 added a commit that referenced this issue Mar 3, 2024
@c4-bot-2
t0x1c issue #28
ad880d6
@c4-judge
Copy link

Picodes marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mitigation-confirmed MR-H-05 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c4-judge @c4-bot-6