Skip to content

Commit

Permalink
Report for issue #964 updated by EloiManuel
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Apr 19, 2023
1 parent ecde3a0 commit e582106
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions data/EloiManuel-Q.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Note that this is my first submission at Code4rena and I am still figuring out h
| L | Low Risk | Potential risk |
| NC | Non-critical | Non risky findings |

| Total Found Issues | 4 |
| Total Found Issues | 5 |
|:--:|:--:|

### Low Risk Issues
Expand All @@ -25,8 +25,9 @@ Note that this is my first submission at Code4rena and I am still figuring out h
| [NC-01] | Missing or vague error messages |
| [NC-02] | Constants should be defined rather than using magic numbers |
| [NC-03] | Inconsistent Documentation |
| [NC-04] | Unnecessary Import |

| Total Non-critical Risk Issues | 3 |
| Total Non-critical Risk Issues | 4 |
|:--:|:--:|

### [L-01] `restructureCapTable()` incorrect burning mechanism
Expand Down Expand Up @@ -57,13 +58,13 @@ Some `require` statements do not have an error message or are the error messages
contracts/Position.sol
53: require(initPeriod >= 3 days); // must be at least three days, recommended to use higher values
```
```

```solidity
contracts/Equity.sol
276: require(canRedeem(msg.sender));
```
```

```solidity
contracts/StablecoinBridge.sol
Expand Down Expand Up @@ -112,4 +113,11 @@ Furthermore, on Equity.sol, it says that equity could be negative when it is usi

```solidity
300: * If there is less than 1000 ZCHF in equity left (maybe even negative),
```

### [NC-04] | Unnecessary Import
The following import in `PositionFactory.sol` was not found to be necessary:

```solidity
5: import "./IFrankencoin.sol";
```

0 comments on commit e582106

Please sign in to comment.