Buyer in bad faith may not accept ERC1155

[code423n4]

Lines of code

https://github.com/code-423n4/2022-10-blur/blob/HEAD/contracts/BlurExchange.sol#L540-L541

Vulnerability details

Impact

Refer to this code-423n4/2022-07-fractional-findings#212

A malicious proposer can start a _executeTokenTransfer() using a contract that cannot receive ERC1155 tokens, and if the execute() fails, This prevents a new order from being started.

Proof of Concept

    function _executeTokenTransfer(
        address collection,
        address from,
        address to,
        uint256 tokenId,
        uint256 amount,
        AssetType assetType
    ) internal {
        /* Assert collection exists. */
        require(_exists(collection), "Collection does not exist");

        /* Call execution delegate. */
        if (assetType == AssetType.ERC721) {
            executionDelegate.transferERC721(collection, from, to, tokenId);
        } else if (assetType == AssetType.ERC1155) {
            executionDelegate.transferERC1155(collection, from, to, tokenId, amount);
        }
    }

Tools Used

vscode

Recommended Mitigation Steps

Consider saving the status of the after a failed order and implementing functions to allow the proposer to withdraw the ERC1155 tokens and eth

[GalloDaSballo]

Order cannot be settled
New orders can still be executed
User willingly walks into a trade without doing DD

[blur-io-toad]

Agreed this should be QA

[GalloDaSballo]

Downgrading to Low Severity as this is self-inflicted