Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #500

Open
code423n4 opened this issue Jul 14, 2022 · 0 comments
Open

QA Report #500

code423n4 opened this issue Jul 14, 2022 · 0 comments
Labels
bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

L-1 UNUSED RECIEVE() FUNCTION WILL LOCK ETHER IN CONTRACT
If the intention is for Ether to be used the function should call another function, otherwise it should revert.
Vault.sol L#32

L-2 MISSING CHECKS FOR ADDRESS(0X0) WHEN ASSIGNING VALUES TO ADDRESS STATE VARIABLES
FERC1155.sol L#199

N-1 NATSPEC IS INCOMPLETE
There are couple instances of this issue: that are missing the @return
FERC1155.sol L#240
FERC1155.sol L#290
FERC1155.sol L#301
FERC1155.sol L#309
FERC1155.sol L#314
FERC1155.sol L#330
FERC1155.sol L#350
@code423n4 code423n4 added bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 14, 2022
code423n4 added a commit that referenced this issue Jul 14, 2022
@code423n4
asutorufos issue #500
1260e76
@stevennevins stevennevins added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevennevins @code423n4