Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #488

Open
code423n4 opened this issue Jul 14, 2022 · 1 comment
Open

QA Report #488

code423n4 opened this issue Jul 14, 2022 · 1 comment
Labels
bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

  1. Missing zero address check
    The following functions are missing a zero address check, which may cause vaults ownership to become address(0).

**Occurrences in:
https://github.com/code-423n4/2022-07-fractional/blob/main/src/FERC1155.sol#L217-L225
https://github.com/code-423n4/2022-07-fractional/blob/main/src/VaultFactory.sol#L73
https://github.com/code-423n4/2022-07-fractional/blob/main/src/VaultRegistry.sol#L74

  1. Missing input validation on array lengths
    The functions below fail to perform input validation on arrays to verify the lengths match.
    A mismatch could lead to an exception or undefined behavior.

https://github.com/code-423n4/2022-07-fractional/blob/main/src/Vault.sol#L73-L82
https://github.com/code-423n4/2022-07-fractional/blob/main/src/VaultRegistry.sol#L165-L177
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/Buyout.sol#L413-L445
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/Migration.sol#L72-L99
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/Migration.sol#L410-L428
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L34-L51
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L58-L70
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L77-L89
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L98-L117
https://github.com/code-423n4/2022-07-fractional/blob/main/src/references/TransferReference.sol#L61-L69
https://github.com/code-423n4/2022-07-fractional/blob/main/src/targets/Transfer.sol#L474
https://github.com/code-423n4/2022-07-fractional/blob/main/src/utils/NFTReceiver.sol#L33-L41

@code423n4 code423n4 added bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 14, 2022
code423n4 added a commit that referenced this issue Jul 14, 2022
@HardlyDifficult
Copy link
Collaborator

Merging with #466

@stevennevins stevennevins added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Development

No branches or pull requests

3 participants