QA Report #488
Labels
bug
Warden finding
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
sponsor disputed
Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
The following functions are missing a zero address check, which may cause vaults ownership to become address(0).
**Occurrences in:
https://github.com/code-423n4/2022-07-fractional/blob/main/src/FERC1155.sol#L217-L225
https://github.com/code-423n4/2022-07-fractional/blob/main/src/VaultFactory.sol#L73
https://github.com/code-423n4/2022-07-fractional/blob/main/src/VaultRegistry.sol#L74
The functions below fail to perform input validation on arrays to verify the lengths match.
A mismatch could lead to an exception or undefined behavior.
https://github.com/code-423n4/2022-07-fractional/blob/main/src/Vault.sol#L73-L82
https://github.com/code-423n4/2022-07-fractional/blob/main/src/VaultRegistry.sol#L165-L177
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/Buyout.sol#L413-L445
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/Migration.sol#L72-L99
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/Migration.sol#L410-L428
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L34-L51
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L58-L70
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L77-L89
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L98-L117
https://github.com/code-423n4/2022-07-fractional/blob/main/src/references/TransferReference.sol#L61-L69
https://github.com/code-423n4/2022-07-fractional/blob/main/src/targets/Transfer.sol#L474
https://github.com/code-423n4/2022-07-fractional/blob/main/src/utils/NFTReceiver.sol#L33-L41
The text was updated successfully, but these errors were encountered: