Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reordering struct fields #96

Open
code423n4 opened this issue Nov 16, 2021 · 1 comment
Open

reordering struct fields #96

code423n4 opened this issue Nov 16, 2021 · 1 comment
Assignees
@maximebrugel
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

NestedRecords line 22 - you can save storage by reordering Holding struct fields in the following way:

original:
struct Holding {
address token;
uint256 amount;
bool isActive;
}

change to:

struct Holding {
    uint256 amount;
    address token;
    bool isActive;
}
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 16, 2021
code423n4 added a commit that referenced this issue Nov 16, 2021
@code423n4
pants issue #96
4c9b1ba
@adrien-supizet adrien-supizet added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 19, 2021
@maximebrugel
Copy link
Collaborator

maximebrugel commented Nov 19, 2021 •
edited
Loading

Before :
image

After :
image

@maximebrugel maximebrugel mentioned this issue Nov 25, 2021
Merged
@maximebrugel maximebrugel self-assigned this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @adrien-supizet @code423n4