Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DummyRouter.sol .transfer isn't safe #92

Open
code423n4 opened this issue Nov 16, 2021 · 2 comments
Open

DummyRouter.sol .transfer isn't safe #92

code423n4 opened this issue Nov 16, 2021 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

DummyRouter.sol .transfer isn't safe - with USDT can steal tokens (dummyswapToken).

We know this is a dummy contract but this should also be safe. Therefore we ask for low-risk and not high-risk.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 16, 2021
code423n4 added a commit that referenced this issue Nov 16, 2021
@code423n4
pants issue #92
dfa8151
@adrien-supizet
Copy link
Collaborator

adrien-supizet commented Nov 19, 2021 •
edited
Loading

Safety here is pointless, this kind of dummy contract is only used for local tests to mock 0x behavior as shown in the project.

@adrien-supizet adrien-supizet added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Nov 19, 2021
@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

I assume that DummyRouter.sol should have been out of scope. Not stated, so the issue is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrien-supizet @alcueca @code423n4