Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index param to remove in function argument to reduce gas. #115

Open
code423n4 opened this issue Nov 17, 2021 · 2 comments
Open

Add index param to remove in function argument to reduce gas. #115

code423n4 opened this issue Nov 17, 2021 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L79

Add current index of operator in function call, and check if operators[index] == operator.
If not, revert.

This will reduce gas.

Tools Used

Recommended Mitigation Steps

Remove by setting specific index, and add checker with that index
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
xYrYuYx issue #115
e64b229
@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 19, 2021
@maximebrugel
Copy link
Collaborator

Will change with #58

@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Different issue, though

@alcueca alcueca reopened this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @alcueca @code423n4