Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused Named Return #105

Open
code423n4 opened this issue Nov 17, 2021 · 1 comment
Open

Unused Named Return #105

code423n4 opened this issue Nov 17, 2021 · 1 comment
Assignees
@maximebrugel
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

Removing unused named return variables can reduce gas usage and improve code clarity.

Proof of Concept

Unused named return:
https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L69

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Remove the unused named return
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
ye0lde issue #105
e11ded0
@adrien-supizet adrien-supizet mentioned this issue Nov 19, 2021
Closed
@adrien-supizet adrien-supizet added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 19, 2021
@maximebrugel maximebrugel mentioned this issue Nov 29, 2021
Merged
@maximebrugel maximebrugel self-assigned this Nov 30, 2021
@alcueca alcueca added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed G (Gas Optimization) labels Dec 3, 2021
@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Raising the severity to non-critical to account for the code clarity issues (#95)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximebrugel @adrien-supizet @alcueca @code423n4