Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use msg.sender rather than _msgSender() in FeeSplitter.receive #1

Open
code423n4 opened this issue Nov 11, 2021 · 0 comments
Open

use msg.sender rather than _msgSender() in FeeSplitter.receive #1

code423n4 opened this issue Nov 11, 2021 · 0 comments
Assignees
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

TomFrench

Vulnerability details

Impact

Gas costs

Proof of Concept

In the receive function of FeeSplitter we check that the address sending ETH is the WETH contract:
https://github.com/code-423n4/2021-11-nested/blob/5d113967cdf7c9ee29802e1ecb176c656386fe9b/contracts/FeeSplitter.sol#L74

As we can safely say that the WETH contract will never send a metatransaction, we can just use msg.sender and avoid the extra gas costs of _msgSender()

Recommended Mitigation Steps

Replace _msgSender() with msg.sender

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 11, 2021
code423n4 added a commit that referenced this issue Nov 11, 2021
@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 16, 2021
@maximebrugel maximebrugel self-assigned this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

2 participants