Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create korean.json #320

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Create korean.json #320

merged 1 commit into from
Jul 31, 2023

Conversation

MrMooky
Copy link
Contributor

@MrMooky MrMooky commented Jan 13, 2023

Building on a closed PR, I created a new one for Korean translation. I had one of my (Korean) customers quickly look over and got "There seems to be no problem with what you sent.".

@florianeckerstorfer florianeckerstorfer merged commit 65d9ea2 into cocur:main Jul 31, 2023
@florianeckerstorfer
Copy link
Member

Thank you so much for the PR. And sorry for the talking so long to merge it.

@dpDesignz
Copy link

dpDesignz commented Aug 4, 2023

@florianeckerstorfer Thanks for adding this! I've just started supporting Korean for one of my clients and this has come in super helpful. How can I add this to my project as I see it's not in the release code yet :(

@florianeckerstorfer
Copy link
Member

@dpDesignz Released a new version 4.4

@dpDesignz
Copy link

dpDesignz commented Aug 5, 2023

@dpDesignz Released a new version 4.4

@florianeckerstorfer Thanks, I've updated to 4.4.0, but I'm still getting a ruleset 'korean' does not exist error. Am I missing a step?

@florianeckerstorfer
Copy link
Member

@dpDesignz It is not a default rule, you need to activate it

$slugify->activateRuleSet("korean");

@dpDesignz
Copy link

dpDesignz commented Aug 5, 2023

@dpDesignz It is not a default rule, you need to activate it

$slugify->activateRuleSet("korean");

@florianeckerstorfer this is my code which I'm getting the error with

// Get SEO friendly URL
$url = new Slugify();
$url->activateRuleSet('korean');
$url = $url->slugify($string);

It's the $url->activateRuleSet('korean); line that I'm getting the ruleset 'korean' does not exist error on

I see Run php bin/generate-default.php as step 3 for adding a language which I'm not sure has been done? I tried to download the repo to do this myself but I couldn't get it to download the entire repo, it would only download the release for some reason.

@dpDesignz
Copy link

Hey @florianeckerstorfer, just following this up please? :) It's still not working for me and I'm not sure where to look to test this.

@florianeckerstorfer
Copy link
Member

@dpDesignz Sorry, my bad I didn't generate the default ruleset. Should be fixed in v4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants