-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create korean.json #320
Create korean.json #320
Conversation
Thank you so much for the PR. And sorry for the talking so long to merge it. |
@florianeckerstorfer Thanks for adding this! I've just started supporting Korean for one of my clients and this has come in super helpful. How can I add this to my project as I see it's not in the release code yet :( |
@dpDesignz Released a new version 4.4 |
@florianeckerstorfer Thanks, I've updated to 4.4.0, but I'm still getting a |
@dpDesignz It is not a default rule, you need to activate it
|
@florianeckerstorfer this is my code which I'm getting the error with // Get SEO friendly URL
$url = new Slugify();
$url->activateRuleSet('korean');
$url = $url->slugify($string); It's the I see |
Hey @florianeckerstorfer, just following this up please? :) It's still not working for me and I'm not sure where to look to test this. |
@dpDesignz Sorry, my bad I didn't generate the default ruleset. Should be fixed in v4.5.0 |
Building on a closed PR, I created a new one for Korean translation. I had one of my (Korean) customers quickly look over and got "There seems to be no problem with what you sent.".