Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use retainedFileCountLimit and CompressionLevel.NoCompression #17

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

schaapkabap
Copy link
Contributor

Removed the throw new ArgumentException to have the possibility to use retainedFileCountLimit and CompressionLevel.NoCompression
Linked to issue #16

@schaapkabap schaapkabap marked this pull request as ready for review May 6, 2023 09:52
@Athimmas
Copy link

Will this ever be merged?

I need this feature.

@cocowalla
Copy link
Owner

@Athimmas @schaapkabap I haven't had much time lately, but I'll try to (finally!) look at this PR this week 👍

@cocowalla cocowalla merged commit 64c2faa into cocowalla:master Feb 16, 2024
@cocowalla
Copy link
Owner

Version 1.0.5 is now published to NuGet: https://www.nuget.org/packages/Serilog.Sinks.File.Archive/1.0.5

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants