Proper Casing for Node Callback Getters and Setters #14794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgod
changed the title
|
@jgod Thanks. But i think it is better deprecated wrong functions and add correctly functions. And could you please fix conflict? |
|
Dear Justin Godesky(@jgod) & (@minggo), We are working on identifying redundant development and duplicate pull requests. We have found there is a closed pull request: #7565 which might be duplicate to this one. So maybe this pull request should be closed ? We would really appreciate if you could help us to validate and give us some feedback. |
|
Thanks @FancyCoder0 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The casing isn't consistent across getters and setters for callbacks in CCNode.
I'm probably missing updates elsewhere in the codebase, but this is mostly a suggestion.