libtcgtpm: update _plat__NVEnable and _plat__NVDisable signatures #576
Conversation
`_plat__NVEnable()` and `_plat__NVDisable()` APIs were updated in the new TCG TPM reference implementation to include an additional `paramSize` parameter (size_t) in their signatures. This patch synchronizes the header file and Rust FFI calls with the new function prototypes. Previously, the outdated header and calls passed fewer arguments than required by the new TCG TPM library. However, this mismatch did not cause issues because the new parameter (paramSize) is not used by the new implementation. Additionally, the first parameter of `_plat__NVDisable()` has changed from `int delete` to `void* platParameter` in the new signature. However, the actual value passed (1) remains the same. In the future we should find a better way to keep the headers synchronized and avoid this problem. Fixes: 9894bf4 ("libtcgtpm: swtich from MS TPM to TCG TPM") Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
|
CC @cclaudio |
There was a problem hiding this comment.
LGTM.
It seems that upstream has re-structured the platform header files. Later we may want to follow what they are doing by generatiing bindings for those headers.
https://github.com/TrustedComputingGroup/TPM/blob/main/TPMCmd/Simulator/src/simulatorPrivate.h , which includes the new platform headers.
Thanks for the review!
Yeah, I agree on that. I'll look into that, removing our intermediate header, and using |
joergroedel
added
in-review
_plat__NVEnable()and_plat__NVDisable()APIs were updated in the new TCG TPM reference implementation to include an additionalparamSizeparameter (size_t) in their signatures.This patch synchronizes the header file and Rust FFI calls with the new function prototypes.
Previously, the outdated header and calls passed fewer arguments than required by the new TCG TPM library. However, this mismatch did not cause issues because the new parameter (paramSize) is not used by the new implementation.
Additionally, the first parameter of
_plat__NVDisable()has changed fromint deletetovoid* platParameterin the new signature. However, the actual value passed (1) remains the same.In the future we should find a better way to keep the headers synchronized and avoid this problem.
Fixes: 9894bf4 ("libtcgtpm: swtich from MS TPM to TCG TPM")