Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel/cpu: add safety comments #553

Merged

Conversation

stefano-garzarella
Copy link
Member

Add safety comments for the inline assembly blocks.

This is part of the effort for #228 and enable undocumented_unsafe_blocks clippy lint.

The original PR was #550 but it was accidentally merged before review, so it was reverted, and now I'm re-posting again.

kernel/src/cpu/msr.rs Outdated Show resolved Hide resolved
Add safety comments for the inline assembly blocks.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
@stefano-garzarella
Copy link
Member Author

v2:

  • rebased on main
  • removed safety comment for write_msr(), we need to mark the entire function unsafe (in another PR) @p4zuu @msft-jlange

@joergroedel joergroedel added the in-review PR is under active review and not yet approved label Dec 6, 2024
@joergroedel joergroedel merged commit c5b465b into coconut-svsm:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review PR is under active review and not yet approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants