igvmbld: Zero stage2 stack page before populating it #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stage2 stack page memory is allocated with a call to construct_mem_data_object(). This function zeros any padding outside of the requested data size but does not zero the memory where the data resides. The stage2 stack is allocated as a full page, meaning the stack is not initialised to zero. This results in uninitialised data being present below the populated stack frame and in the _reserved part of the stack. This commit zeroes the entire stack page to ensure it is initialised. Signed-off-by: Roy Hopkins <roy.hopkins@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stage2 stack page memory is allocated with a call to construct_mem_data_object(). This function zeros any padding outside of the requested data size but does not zero the memory where the data resides.
The stage2 stack is allocated as a full page, meaning the stack is not initialised to zero. This results in uninitialised data being present below the populated stack frame and in the _reserved part of the stack.
This commit zeroes the entire stack page to ensure it is initialised.