-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mm: Add unit tests for kernel mapping, guestmem ops, address checks #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least one test is failing inside the SVSM, so we need that fixed at the minimum. I would also really want the Miri addition to go in, as I'm running Miri tests nightly.
I foresee the complexity of these and future tests growing considerably if we want all to be able to run inside the SVSM. My intention when I wrote and added these tests was to run them offline. For example, I need to either implement new functions that use |
Yes, there are already some tests that are ignored inside the SVSM, for example in #[test]
#[cfg_attr(test_in_svsm, ignore = "<REASON>")]
fn my_test() {} I think you can also omit the reason. |
Add unit tests to evaluate offline correct behavior of valid physical address checking (memory.rs). Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Add unit tests to evaluate offline correct behavior of read and write operations (guestmem.rs). Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Add unit tests to evaluate offline correct behavior of memory components: kernel mappings (address_space.rs). Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
8c22984
to
898e828
Compare
Thanks, I'm doing this, opening new clean PR |
Add unit tests to evaluate offline correct behavior of memory components: kernel mappings (address_space.rs), read and write operations (guestmem.rs) and valid physical address checking (memory.rs).