Skip to content

Commit

Permalink
greq: use Self in various places for better readability
Browse files Browse the repository at this point in the history
Signed-off-by: Carlos López <carlos.lopez@suse.com>
  • Loading branch information
00xc committed Nov 23, 2023
1 parent cc82968 commit b9054f9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 18 deletions.
20 changes: 6 additions & 14 deletions src/greq/msg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,9 @@ impl TryFrom<u8> for SnpGuestRequestMsgType {

fn try_from(v: u8) -> Result<Self, Self::Error> {
match v {
x if x == SnpGuestRequestMsgType::Invalid as u8 => Ok(SnpGuestRequestMsgType::Invalid),
x if x == SnpGuestRequestMsgType::ReportRequest as u8 => {
Ok(SnpGuestRequestMsgType::ReportRequest)
}
x if x == SnpGuestRequestMsgType::ReportResponse as u8 => {
Ok(SnpGuestRequestMsgType::ReportResponse)
}
x if x == Self::Invalid as u8 => Ok(Self::Invalid),
x if x == Self::ReportRequest as u8 => Ok(Self::ReportRequest),
x if x == Self::ReportResponse as u8 => Ok(Self::ReportResponse),
_ => Err(SvsmReqError::invalid_parameter()),
}
}
Expand Down Expand Up @@ -179,7 +175,7 @@ impl SnpGuestRequestMsgHdr {

/// Get [`SnpGuestRequestMsgHdr`] as a mutable slice reference
fn as_slice_mut(&mut self) -> &mut [u8] {
unsafe { from_raw_parts_mut(self as *mut _ as *mut u8, MSG_HDR_SIZE) }
unsafe { from_raw_parts_mut(self as *mut _ as *mut u8, size_of::<Self>()) }
}
}

Expand Down Expand Up @@ -509,19 +505,15 @@ impl SnpGuestRequestExtData {
/// before the object is dropped. Shared pages should not be freed
/// (returned to the allocator)
pub fn set_shared(&mut self) -> Result<(), SvsmReqError> {
const EXT_DATA_SIZE: usize = size_of::<SnpGuestRequestExtData>();

let start = VirtAddr::from(self as *mut Self);
let end = start + EXT_DATA_SIZE;
let end = start + size_of::<Self>();
set_shared_region_4k(start, end)
}

/// Set the C-bit (memory encryption bit) for the Self pages
pub fn set_encrypted(&mut self) -> Result<(), SvsmReqError> {
const EXT_DATA_SIZE: usize = size_of::<SnpGuestRequestExtData>();

let start = VirtAddr::from(self as *mut Self);
let end = start + EXT_DATA_SIZE;
let end = start + size_of::<Self>();
set_encrypted_region_4k(start, end)
}

Expand Down
8 changes: 4 additions & 4 deletions src/greq/pld_report.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ impl SnpReportRequest {
/// Take a slice and return a reference for Self
pub fn try_from_as_ref(buffer: &[u8]) -> Result<&Self, SvsmReqError> {
let buffer = buffer
.get(..size_of::<SnpReportRequest>())
.get(..size_of::<Self>())
.ok_or_else(SvsmReqError::invalid_parameter)?;

let request = unsafe { &*buffer.as_ptr().cast::<SnpReportRequest>() };
let request = unsafe { &*buffer.as_ptr().cast::<Self>() };

if !request.is_reserved_clear() {
return Err(SvsmReqError::invalid_parameter());
Expand Down Expand Up @@ -86,10 +86,10 @@ pub enum SnpReportResponseStatus {
impl SnpReportResponse {
pub fn try_from_as_ref(buffer: &[u8]) -> Result<&Self, SvsmReqError> {
let buffer = buffer
.get(..size_of::<SnpReportResponse>())
.get(..size_of::<Self>())
.ok_or_else(SvsmReqError::invalid_parameter)?;

let response = unsafe { &*buffer.as_ptr().cast::<SnpReportResponse>() };
let response = unsafe { &*buffer.as_ptr().cast::<Self>() };
Ok(response)
}

Expand Down

0 comments on commit b9054f9

Please sign in to comment.