Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix up comments lingering references to file metadata #4339

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Feb 13, 2025

In 6f32adb the manifest.FileMetadata type was renamed to TableMetadata to disambiguate it with manfiest metadata tracking non-sstable files. This commit cleans up some lingering references to 'file metadata,' particularly in comments.

@jbowens jbowens requested a review from a team as a code owner February 13, 2025 15:04
@jbowens jbowens requested a review from RaduBerinde February 13, 2025 15:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 32 files reviewed, all discussions resolved

In 6f32adb the manifest.FileMetadata type was renamed to TableMetadata to
disambiguate it with manfiest metadata tracking non-sstable files. This commit
cleans up some lingering references to 'file metadata,' particularly in
comments.
@jbowens jbowens force-pushed the FileMetadataComment branch from c61950b to 0c5ba60 Compare February 13, 2025 16:30
@jbowens
Copy link
Collaborator Author

jbowens commented Feb 13, 2025

TFTR!

@jbowens jbowens merged commit fd55bca into cockroachdb:master Feb 13, 2025
23 checks passed
@jbowens jbowens deleted the FileMetadataComment branch February 13, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants