[CRDB-44988] bugfix: fix cockroach start arguments #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pritesh-lahoti, I'm working in Devsisters, one of CockroachDB customer. It is very critical bug and should be fixed as soon as possible, because it's already impacting Devsisters' staging, production CRDB clusters. Also, please bump helm chart version in Chart.yaml to release it to the helm repository. |
prafull01
approved these changes
Nov 29, 2024
The cockroach start command was not accepting any arguments after --http-port due to whitespace getting introduced in the template. This PR chomps the whitespace to fix this bug.
pritesh-lahoti
force-pushed
the
cockroach-start-args
branch
from
36cabe6 to
d72bcf6
Compare
prafull01
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cockroach start command was not accepting any arguments after --http-port due to whitespace getting introduced in the template. This PR chomps the whitespace to fix this bug.