Do not use docker images for build and release #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used a custom docker image with `helm` and `aws-cli` installed in order to generate Helm charts and to sync the generated files to S3. This docker image is very outdated and hosted on Docker Hub. To simplify local development, remove docker dependency and keep the dependencies fresher, in this PR: * Removed custom docker image and the wrapper script * `helm` is installed run-time * Use `aws-cli` installed system-wide * Simplified docs Epic: RE-539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used a custom docker image with
helmandaws-cliinstalled in order to generate Helm charts and to sync the generated files to S3. This docker image is very outdated and hosted on Docker Hub.To simplify local development, remove docker dependency and keep the dependencies fresher, in this PR:
helmis installed run-timeaws-cliinstalled system-wideEpic: RE-539