release-19.1: stats,opt: finalize automatic stats cluster settings and join reorder limit setting #36085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes "experimental" from the two existing cluster settings for automatic stats. It also adds two new cluster settings, sql.stats.automatic_collection.fraction_stale_rows and sql.stats.automatic_collection.min_stale_rows, which control the target number of rows in a table that should be stale before statistics on that table are refreshed. Closes cockroachdb#35544 Release note (sql change): Changed the two existing automatic statistics cluster settings to remove "experimental" from the name. Added two new cluster settings to control the target number of stale rows per table that will trigger a statistics refresh.
This commit removes "experimental" from the experimental_reorder_joins_limit session setting. It also adds validation to ensure users cannot set it to a negative value. Fixes cockroachdb#35348 Release note (sql change): Changed the experimental_reorder_joins_limit session setting to remove "experimental" from the name.
|
This change is |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #35754.
/cc @cockroachdb/release
This PR removes "experimental" from the two existing cluster
settings for automatic stats. It also adds two new cluster settings,
sql.stats.automatic_collection.fraction_stale_rowsandsql.stats.automatic_collection.min_stale_rows, which controlthe target number of rows in a table that should be stale before
statistics on that table are refreshed.
This PR also removes "experimental" from the
experimental_reorder_joins_limitsession setting. It also adds validation to ensure users cannot set it to
a negative value.
Closes #35544
Fixes #35348