ui: finish short-term enhancements to cluster overview

[couchand]

This fixes everything from #19512, leaving #20540 and #19945 for future work.

[cockroach-teamcity]

This change is 

[vilterp]

with a minor nit

---

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

pkg/ui/src/views/cluster/containers/clusterOverview/index.tsx, line 17 at r1 (raw file):

// tslint:disable-next-line:no-var-requires
const spinner = require<string>("assets/spinner.gif");

does import spinner from "assets/spinner.gif" work?

---

Comments from Reviewable

[couchand]

Well look at that, your nit made me learn something.

---

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

pkg/ui/src/views/cluster/containers/clusterOverview/index.tsx, line 17 at r1 (raw file):

Previously, vilterp (Pete Vilter) wrote…

does import spinner from "assets/spinner.gif" work?

TBH I just cargo-culted that 😳.

Tried it out. Builds fine (Webpack gets it), but tslint (and maybe tsc) doesn't get it:
Cannot find module 'assets/spinner.gif'.

...

UPDATE: after reading through microsoft/TypeScript#2709 I've found a solution!

I'm not exactly clear on how the import "*.styl" was already working, but perhaps because it was just imported for the side-effect, TS doesn't bother checking for it?

---

Comments from Reviewable

[vilterp]

Nice 👍 LGTM

[couchand]

whoops, missed the file with the important part

[mrtracy]

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

pkg/ui/src/views/cluster/containers/clusterOverview/index.tsx, line 17 at r1 (raw file):

Previously, couchand (Andrew Couch) wrote…

TBH I just cargo-culted that 😳.

Tried it out. Builds fine (Webpack gets it), but tslint (and maybe tsc) doesn't get it:
Cannot find module 'assets/spinner.gif'.

...

UPDATE: after reading through microsoft/TypeScript#2709 I've found a solution!

I'm not exactly clear on how the import "*.styl" was already working, but perhaps because it was just imported for the side-effect, TS doesn't bother checking for it?

RE: Side effect imports, yes, that is correct.

---

Comments from Reviewable

[mrtracy]

---

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

Comments from Reviewable