Skip to content

Conversation

RaduBerinde
Copy link
Member

Changes:

  • 45d293d8 db: make iterator tracking configurable
  • 0d8ff1c3 db: track and report long-standing iterators
  • 0d82adc5 inflight: add data structure to detect long-running operations
  • 14834f0a github: run tests against custom cockroach Go
  • 0ac45a74 metrics: fix TestMetrics flake
  • 98c989b1 metamorphic: fix bug in suffix generation when prefix == startPrefix
  • d37d2f4b pebble: materialize virtual tables only if backing contains >= 30% garbage

Release note: none.
Epic: none.

Changes:

 * [`45d293d8`](cockroachdb/pebble@45d293d8) db: make iterator tracking configurable
 * [`0d8ff1c3`](cockroachdb/pebble@0d8ff1c3) db: track and report long-standing iterators
 * [`0d82adc5`](cockroachdb/pebble@0d82adc5) inflight: add data structure to detect long-running operations
 * [`14834f0a`](cockroachdb/pebble@14834f0a) github: run tests against custom cockroach Go
 * [`0ac45a74`](cockroachdb/pebble@0ac45a74) metrics: fix TestMetrics flake
 * [`98c989b1`](cockroachdb/pebble@98c989b1) metamorphic: fix bug in suffix generation when prefix == startPrefix
 * [`d37d2f4b`](cockroachdb/pebble@d37d2f4b) pebble: materialize virtual tables only if backing contains >= 30% garbage

Release note: none.
Epic: none.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde changed the title go.mod: bump Pebble to 45d293d8d270 go.mod: bump Pebble to 45d293d8d270 (test run) Oct 3, 2025
@cockroach-teamcity
Copy link
Member

🔴 Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
🔴 sec/op 8.006m ±0% 8.173m ±1% +2.09% p=0.000 n=15
🔴 allocs/op 7.787k ±1% 7.818k ±1% +0.40% p=0.010 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/222e8ac/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/222e8ac8effe34603e730cb96e4dc8d9f402534f/bin/pkg_sql_tests benchdiff/222e8ac/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/222e8ac/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/287999c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/287999c7f71ec6fb9d903f21b2a8745eaac6f8ff/bin/pkg_sql_tests benchdiff/287999c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/287999c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=287999c --new=222e8ac ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.098m ±0% 1.174m ±1% +6.86% p=0.000 n=15
🔴 allocs/op 1.869k ±0% 1.899k ±0% +1.61% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/222e8ac/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/222e8ac8effe34603e730cb96e4dc8d9f402534f/bin/pkg_sql_tests benchdiff/222e8ac/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/222e8ac/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/287999c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/287999c7f71ec6fb9d903f21b2a8745eaac6f8ff/bin/pkg_sql_tests benchdiff/287999c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/287999c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=287999c --new=222e8ac ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.906m ±0% 1.973m ±0% +3.50% p=0.000 n=15
🔴 allocs/op 3.794k ±0% 3.868k ±0% +1.95% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/222e8ac/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/222e8ac8effe34603e730cb96e4dc8d9f402534f/bin/pkg_sql_tests benchdiff/222e8ac/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/222e8ac/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/287999c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/287999c7f71ec6fb9d903f21b2a8745eaac6f8ff/bin/pkg_sql_tests benchdiff/287999c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/287999c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=287999c --new=222e8ac ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/222e8ac8effe34603e730cb96e4dc8d9f402534f/18222532410-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/287999c7f71ec6fb9d903f21b2a8745eaac6f8ff/18222532410-1/\* old/

built with commit: 222e8ac8effe34603e730cb96e4dc8d9f402534f

@cockroach-teamcity cockroach-teamcity added the X-perf-check Microbenchmarks CI: Added to a PR if a performance regression is detected and should be checked label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-perf-check Microbenchmarks CI: Added to a PR if a performance regression is detected and should be checked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants