sql: deflake TestBackfillWithProtectedTS #139774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen that the DELETE and INSERT step can fail in this test, which occurs before we manually send the table into the GC queue. To reduce the chance of this happening, we use a longer gc.ttl. Release note: None
rafiss
added
backport-24.1.x
|
This change is |
fqazi
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
|
bors r+ |
This was referenced Jan 24, 2025
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #139775: branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #139493: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #139281: branch-release-24.1, branch-release-24.2, branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen that the DELETE and INSERT step can fail in this test, which occurs before we manually send the table into the GC queue. To reduce the chance of this happening, we use a longer gc.ttl.
fixes #139493
fixes #139281
fixes #139775
Release note: None