workload/schemachange: add unique constraint hits duplicate key errors #130361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the ALTER TABLE ADD UNIQUE CONSTRAINT operation could encounter duplicate key errors. This would occur because our scan query was not exhaustive enough. To address this and to help stabilize the workload, we will allow unique violations to be potential commit errors. Fixes: cockroachdb#129909 Release note: None
fqazi
requested review from
herkolategan and
renatolabs
and removed request for
a team
|
This change is |
spilchen
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @renatolabs)
|
@spilchen TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ALTER TABLE ADD UNIQUE CONSTRAINT operation could encounter duplicate key errors. This would occur because our scan query was not exhaustive enough. To address this and to help stabilize the workload, we will allow unique violations to be potential commit errors.
Fixes: #129909
Release note: None