Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: roachtest: label randomized tests #130134

Conversation

nameisbhaskar
Copy link
Contributor

@nameisbhaskar nameisbhaskar commented Sep 5, 2024

Backport 1/1 commits from #127974.

/cc @cockroachdb/release


This commit introduces a new field in the TestSpec to allow tests to be labeled as Randomized. Crucially, randomized tests are exempt from test selection.

We also update existing randomized tests to use the new field, including mixedversion tests, sqlsmith, tlp, and costfuzz.

Epic: none

Release note: None
Release justification: test engineering changes

@nameisbhaskar nameisbhaskar requested a review from a team as a code owner September 5, 2024 07:34
@nameisbhaskar nameisbhaskar requested review from herkolategan and renatolabs and removed request for a team September 5, 2024 07:34
Copy link

blathers-crl bot commented Sep 5, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 5, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@herkolategan
Copy link
Collaborator

Dual commit on this one looks a bit strange, was it a merge conflict?

@nameisbhaskar
Copy link
Contributor Author

Dual commit on this one looks a bit strange, was it a merge conflict?

Strange. Seems like some issue while resolving merge conflict. I will get this fixed. Thanks for pointing out.

This commit introduces a new field in the `TestSpec` to allow tests to be labeled as `Randomized`. Crucially, randomized tests are exempt from test selection.

We also update existing randomized tests to use the new field, including `mixedversion` tests, sqlsmith, tlp, and costfuzz.

Epic: none

Release note: None
@nameisbhaskar
Copy link
Contributor Author

@herkolategan, I fixed the commits.

@nameisbhaskar nameisbhaskar merged commit a0f48c2 into cockroachdb:release-24.1 Sep 5, 2024
19 of 20 checks passed
@nameisbhaskar nameisbhaskar deleted the backportrelease-24.1-127974 branch September 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants