logical: disallow replicating into a table with non-nullable column i… #130127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
navsetlur
force-pushed
the
ldr_column_family
branch
from
29b4554
to
c11de42
Compare
|
@navsetlur can i ask you to review the test flakes on this before i review? |
navsetlur
force-pushed
the
ldr_column_family
branch
2 times, most recently
from
8f7fead
to
7034c43
Compare
msbutler
reviewed
Sep 6, 2024
| @@ -154,6 +157,10 @@ func createLogicalReplicationStreamPlanHook( | |||
| } | |||
| break | |||
| } | |||
| // The rowid column is always NOT NULL and is never explicitly set by the row processor, so ignore it | |||
| if requireNotNull && !col.Nullable && col.Name != "rowid" { | |||
There was a problem hiding this comment.
the col.Name != "rowid" isn't the right check, as it assumes the pk is one column named "rowid". I think the right check is
requireNotNull && !col.Nullable && colNotInPrimaryKey(col.ID)
I just made up that last function, but you have the info required to create it. I would post in -eng about this, as I'm not totally confident this is the right check.
navsetlur
force-pushed
the
ldr_column_family
branch
from
7034c43
to
53b832f
Compare
…n a column family LDR streams currently process incoming data via a row processor. In order to apply column family updates from the rangefeed which don't contain a full row, columns not in the family will have to be nullable in order to write the entire row. This code verifies that when starting the LDR stream. Release note: none Informs: cockroachdb#129892
navsetlur
force-pushed
the
ldr_column_family
branch
from
53b832f
to
a18fb29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n a column family
LDR streams currently process incoming data via a row processor. In order to apply column family updates from the rangefeed which don't contain a full row, columns not in the family will have to be nullable in order to write the entire row. This code verifies that when starting the LDR stream.
Release note: none
Informs: #129892