-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: obs: export metrics about Go GC Assist work; add chart #130126
release-23.2: obs: export metrics about Go GC Assist work; add chart #130126
Conversation
This commit introduced functions to extract exposed metrics in go runtime metrics api. The runtime metrics is sampled along in SampleEnvironment call every 10 seconds. New metric GcAssistNS is added as an estimate to amount of effort of user go routines assist in gc activities in nanoseconds. Fixes: cockroachdb#88178 Release note: None
This commit adds a line chart contains gc assist duration on the runtime page. The goal is to present the estimated time user go routines spend on assisting gc tasks. Informs: cockroachdb#118875 Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you manually confirm that this works when compiled with v23.2 and its version of Go? The runtime/metrics
is unfortunately weakly typed and won't complain about unsupported metrics, it will just populate values with KindBad
when sampling at runtime.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @kyle-a-wong)
Yes, that proves it. Thanks for checking. |
Adding a note here that this technically adds new functionality, but there is precedence for backporting obs changes, and we're ok with that. |
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release
Release note: None.
Release justification: Low risk observability change.