kvtenant: expose reader status via connector #130115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
dt
force-pushed
the
tenant-readfrom-metadata
branch
from
2ce40e2
to
caabb5b
Compare
dt
force-pushed
the
tenant-readfrom-metadata
branch
from
caabb5b
to
943b62a
Compare
msbutler
approved these changes
Sep 4, 2024
dt
changed the title
dt
force-pushed
the
tenant-readfrom-metadata
branch
3 times, most recently
from
b2b7505
to
331f107
Compare
This adds a new API in the tenant connector to expose to a tenant if it is expected to be a reader tenant and if so, of which tenant and as of what time. Actually configuring itself to be a reader and do so at that timestamp is left to the reader tenant's own devices, and is not included here; this change only adds the metadata to the tenant record and the API exposed to the tenant for fetching it. Release note: none. Epic: none.
dt
force-pushed
the
tenant-readfrom-metadata
branch
from
331f107
to
8af2169
Compare
msbutler
approved these changes
Sep 5, 2024
|
TFTR! bors r+ |
|
seems that bors crashed and didn't send an error back. going to try this again. |
|
bors r- |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
130115: kvtenant: expose reader status via connector r=msbutler a=dt Tracking if a tenant is intended to be a reader of another tenant in the tenant record allows the system tenant to expose a new API in the tenant connector so that if a tenant intended to be a reader tenant calls the API, it can be informed of the tenant from which it should read and the timestamp -- fetched from the system tenant's PCR job for now -- at which it should do so. Actually configuring itself to be a reader and do so at that timestamp is left to the reader tenant's own devices, and is not included here; this change only adds the metadata to the tenant record and the API exposed to the tenant for fetching it. Release note: none. Epic: none. Co-authored-by: David Taylor <tinystatemachine@gmail.com>
|
Build failed: |
|
Unrelated flake bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking if a tenant is intended to be a reader of another tenant in the tenant record allows the system tenant to expose a new API in the tenant connector so that if a tenant intended to be a reader tenant calls the API, it can be informed of the tenant from which it should read and the timestamp -- fetched from the system tenant's PCR job for now -- at which it should do so. Actually configuring itself to be a reader and do so at that timestamp is left to the reader tenant's own devices, and is not included here; this change only adds the metadata to the tenant record and the API exposed to the tenant for fetching it.
Release note: none.
Epic: none.