rpc,tenantcapabilities: add cross-tenant reads to 'all' capabilities #130102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
force-pushed
the
allow-reads
branch
2 times, most recently
from
b3cd869
to
c59ec2c
Compare
The allow-all capability check now also allows 'cross tenant reads', which are defined as read requests made by a non-system tenant to spans not contained by its tenant span. This is added to the capability authorizer API, but is not a defined capability and cannot be granted to tenants; it is only implicitly granted to tenants that are implicitly understood to have 'all' capabilities, such as in shared service. Release note: none. Epic: none.
fqazi
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler and @stevendanna)
stevendanna
approved these changes
Sep 5, 2024
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allow-all capability check now also allows 'cross tenant reads', which are defined as read requests made by a non-system tenant to spans not contained by its tenant span. This is added to the capability authorizer API, but is not a defined capability and cannot be granted to tenants; it is only implicitly granted to tenants that are implicitly understood to have 'all' capabilities, such as in shared service.
Release note: none.
Epic: none.