Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: make sql.txn.repeatable_read_isolation.enabled public #130089

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

nvanbenschoten
Copy link
Member

This commit makes the sql.txn.repeatable_read_isolation.enabled cluster setting public, as part of moving REPEATABLE READ isolation into a public preview.

Epic: None

Release note (sql change): The cluster setting
sql.txn.repeatable_read_isolation.enabled was added and defaults to false. When set to true, the following statements will configure transactions to run under REPEATABLE READ isolation, rather than being automatically interpreted as SERIALIZABLE.

  • BEGIN TRANSACTION ISOLATION LEVEL REPEATABLE READ
  • SET TRANSACTION ISOLATION LEVEL REPEATABLE READ
  • SET default_transaction_isolation = 'repeatable read'
  • SET SESSION CHARACTERISTICS AS TRANSACTION ISOLATION LEVEL REPEATABLE READ

This setting was added since REPEATABLE READ transactions are a preview feature, so usage of it is opt-in for v24.3. In a future CockroachDB major version, this setting will change to default to true.

Copy link

blathers-crl bot commented Sep 4, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

docs/generated/settings/settings-for-tenants.txt Outdated Show resolved Hide resolved
This commit makes the `sql.txn.repeatable_read_isolation.enabled` cluster
setting public, as part of moving REPEATABLE READ isolation into a public
preview.

Epic: None

Release note (sql change): The cluster setting
sql.txn.repeatable_read_isolation.enabled was added and defaults to false.
When set to true, the following statements will configure transactions to
run under REPEATABLE READ isolation, rather than being automatically
interpreted as SERIALIZABLE.
- BEGIN TRANSACTION ISOLATION LEVEL REPEATABLE READ
- SET TRANSACTION ISOLATION LEVEL REPEATABLE READ
- SET default_transaction_isolation = 'repeatable read'
- SET SESSION CHARACTERISTICS AS TRANSACTION ISOLATION LEVEL REPEATABLE READ

This setting was added since REPEATABLE READ transactions are a preview
feature, so usage of it is opt-in for v24.3. In a future CockroachDB major
version, this setting will change to default to true.
@nvanbenschoten
Copy link
Member Author

TFTR!

bors r=dikshant

@craig craig bot merged commit ca2bca6 into cockroachdb:master Sep 5, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants