-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: include license expiration type and time into uiconfig
response
#120475
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
ac040d3
to
9ea2850
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @abarganier, @koorosh, and @xinhaoz)
-- commits
line 2 at r1:
nit: length. wrap at 80 chars.
9ea2850
to
8060144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @abarganier and @xinhaoz)
Previously, dhartunian (David Hartunian) wrote…
nit: length. wrap at 80 chars.
Done.
8060144
to
ad8b3a9
Compare
This change extends response for `uiconfig` endpoint which now contains information about license type and time until license expires. Release note: None
ad8b3a9
to
000764b
Compare
bors r+ |
Build succeeded: |
120490: ui: show license expiration alert in Db Console r=koorosh a=koorosh With this change, new alert message is shown in Db Console when license is expired or less than 15 days left before it will expire. This change doesn't affect clusters that doesn't have any license set. Release note (ui change): show alert message in Db Console when license is expired or close to expire. Depends on: #120475 Resolves: #98589 Epic: None Screens: 1. Less than 15 days before license expires <img width="1215" alt="Screenshot 2024-03-14 at 13 26 18" src="https://github.com/cockroachdb/cockroach/assets/3106437/54f18792-d16f-43d1-a439-bd04e7a91abd"> 2. License expired <img width="1215" alt="Screenshot 2024-03-14 at 13 25 26" src="https://github.com/cockroachdb/cockroach/assets/3106437/ec9b924a-7800-4cf9-a164-9f4f5b49e91f"> 3. License expired today <img width="1215" alt="Screenshot 2024-03-14 at 13 25 59" src="https://github.com/cockroachdb/cockroach/assets/3106437/38a29b0d-47c3-447a-beb5-d557b58bcfc9"> 120505: sql: deflake TestTrackOnlyUserOpenTransactionsAndActiveStatements r=rafiss a=rafiss This changes the test to block in AfterExecute rather than OnTxnFinish, which should make the active statements assertion less flaky. It also fixes a testing bug where the SELECT FOR UPDATE was not in a txn. fixes #120042 fixes #120235 fixes #119829 Release note: None 120547: ccl/cliccl: avoid opening Engine in debug encryption-decrypt r=sumeerbhola a=jbowens Adapt the `debug encryption-decrypt` command to avoid actually opening the Engine and instead only open the filesystem environment. This allows the command to be used even when missing or corrupt files prevent the Engine from being opened. Epic: none Fix #96699. Release note: none 120562: build: update `rules_go` r=jlinder a=rickystewart ... to pull in `0e7e4e31aa49f1afbb402fbb4895f38bc702c88c`. See bazelbuild/rules_go#3890 This reverts a change in bazelbuild/rules_go#3824 which makes it much more difficult to see build errors. Epic: none Release note: None Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Jackson Owens <jackson@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
This change extends response for
uiconfig
endpoint which now contains information about license type and time until license expires.Related: #98589
Release note: None
Epic: None