Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump some core dependencies #108858

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Aug 16, 2023

Unfortunately we're still getting nogo crashes. Try bumping these
dependencies even further.

Informs #99988.

Epic: none
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Unfortunately we're still getting `nogo` crashes. Try bumping these
dependencies even further.

Informs cockroachdb#99988.

Epic: none
Release note: None
@rickystewart rickystewart changed the title [WIP] *: bump some core dependencies *: bump some core dependencies Aug 17, 2023
@rickystewart rickystewart marked this pull request as ready for review August 17, 2023 18:13
@rickystewart rickystewart requested a review from a team as a code owner August 17, 2023 18:13
@rickystewart rickystewart requested a review from knz August 17, 2023 18:13
@knz
Copy link
Contributor

knz commented Aug 17, 2023

@rickystewart I'll look at those manually, but in the future would it be possible to have the dep generator also list a markdown table that links to the repos with the diff?

Something like:

Package Link to Diff
golang.org/x/net auto-generated link to diff between old and new SHA on github

@rickystewart
Copy link
Collaborator Author

Hmm, you mean like as a blathers comment or something? Or where else would this table be.

@knz
Copy link
Contributor

knz commented Aug 17, 2023

yes blathers

@knz
Copy link
Contributor

knz commented Aug 17, 2023

@rickystewart
Copy link
Collaborator Author

TFTR!

bors r=knz

@craig craig bot merged commit 02065f5 into cockroachdb:master Aug 17, 2023
2 checks passed
@craig
Copy link
Contributor

craig bot commented Aug 17, 2023

Build succeeded:

@rickystewart
Copy link
Collaborator Author

blathers backport 23.1

@blathers-crl
Copy link

blathers-crl bot commented Aug 22, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 54140f3 to blathers/backport-release-23.1-108858: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants