Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: default sort on jobs page should be creation time #30418

Closed
awoods187 opened this issue Sep 19, 2018 · 1 comment
Closed

ui: default sort on jobs page should be creation time #30418

awoods187 opened this issue Sep 19, 2018 · 1 comment
Assignees
@couchand
Labels
A-webui-jobs-and-events C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Milestone
2.1

Comments

@awoods187
Copy link
Contributor

awoods187 commented Sep 19, 2018 •
edited
Loading

The order of jobs in the admin ui isn't consistent:
job 1
image
job 2 the same as job 1
image

These are the same jobs that i've now run a few times. It's a bit confusing to me that they aren't presented in the same order each time. I notice this because I look at the time left on jobs and see some complete and some in progress that take different times. It makes me think that the times aren't predictable even though the jobs are actually pretty predictable in overall timing.

I'd argue that there should be a consistent experience for the jobs table view here.

cc @piyush-singh
@couchand
Copy link
Contributor

It looks like #18137 added a new column, but didn't update the default sort. It should default to Creation Time, not User.

@couchand couchand added A-webui-jobs-and-events C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Sep 19, 2018
@couchand couchand added this to the 2.1 milestone Sep 19, 2018
@couchand couchand self-assigned this Sep 19, 2018
@couchand couchand changed the title Inconsistent view of in-progress jobs in admin ui ui: inconsistent view of in-progress jobs in admin ui Sep 19, 2018
@couchand couchand changed the title ui: inconsistent view of in-progress jobs in admin ui ui: default sort on jobs page should be creation time Sep 19, 2018
couchand added a commit to couchand/cockroach that referenced this issue Sep 19, 2018
@couchand
ui: fix default jobs page sort
670bef4 
In cockroachdb#18137 a column was added, but the default sort
(which is specified by index) was not updated.  This
updates it to correctly sort on creation time.

Fixes: cockroachdb#30418
Release note (admin ui change): Fixes an issue where
the default sort on the Jobs page was incorrectly
the User column rather than the Creation Time.
@couchand couchand mentioned this issue Sep 19, 2018
Merged
craig bot pushed a commit that referenced this issue Sep 19, 2018
@jordanlewis @couchand
Merge #30394 #30423
4f5b3b4 
30394: sqlbase: bugfix in rowfetcher with multiple cfs r=jordanlewis a=jordanlewis

A bug (introduced during the 2.1 cycle) caused scans issued via distsql
against tables with multiple column families to return incorrect results
or panic the server if some of the column families were marked as
non-nullable. This bug could only occur in distsql because it only
manifested when a rowfetcher was initialized with multiple input spans,
which only occurs in distsql where a particular node owns 2
non-contiguous portions of the keyspace. In this case, the code would
misinterpret the empty response from the scan request on the second
input span to mean that there was a limit on the last scan and that
we might have entered a new input span, which caused the rowfetcher to
mark the current row as ended and expect a full row starting from the
next key retrieved.

This was not the case, as this could happen in normal circumstances.
When a row had multiple column families, the rowfetcher would fail to
remember the results it had already seen for the earlier column families
in a row, if a batch happened to end half way through the row's column
families, and return incorrect and/or panic depending on the definition
of the table.

This patch removes this problem and adds a test for it. The test is a
little complicated but I verified that it does in fact panic before the
patch. It should catch problems like this in the future. We had no
explicit tests of the rowfetcher before with multiple input spans.

Note that this patch also deletes a test case, that tests correct
behavior in the case of seeing duplicate rows from the input stream
during an index join. This test case is contrived - index joins can
never encounter duplicate rows from the input stream - so it's safe to
delete.

Closes #29374.
Partially reverts #23474. The code no longer has protection against the condition that that PR was trying to guard against. But I don't think this is a problem in practice. If it crops up in new code it'll be very easy to notice and fix at that point.

cc @vivekmenezes

Release note: None

30423: ui: fix default jobs page sort r=couchand a=couchand

In #18137 a column was added, but the default sort
(which is specified by index) was not updated.  This
updates it to correctly sort on creation time.

Fixes: #30418
Release note (admin ui change): Fixes an issue where
the default sort on the Jobs page was incorrectly
the User column rather than the Creation Time.

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
@craig craig bot closed this as completed in #30423 Sep 19, 2018
couchand added a commit to couchand/cockroach that referenced this issue Sep 19, 2018
@couchand
ui: fix default jobs page sort
f2f8eba 
In cockroachdb#18137 a column was added, but the default sort
(which is specified by index) was not updated.  This
updates it to correctly sort on creation time.

Fixes: cockroachdb#30418
Release note (admin ui change): Fixes an issue where
the default sort on the Jobs page was incorrectly
the User column rather than the Creation Time.
@couchand couchand mentioned this issue Sep 19, 2018
Merged
couchand added a commit to couchand/cockroach that referenced this issue Sep 19, 2018
@couchand
ui: fix default jobs page sort
5165c55 
In cockroachdb#18137 a column was added, but the default sort
(which is specified by index) was not updated.  This
updates it to correctly sort on creation time.

Fixes: cockroachdb#30418
Release note (admin ui change): Fixes an issue where
the default sort on the Jobs page was incorrectly
the User column rather than the Creation Time.
@couchand couchand mentioned this issue Sep 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@couchand couchand

Labels
A-webui-jobs-and-events C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@couchand @awoods187