Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: upgrade/oldVersion=v2.0.0/nodes=5 failed on master #28452

Closed
cockroach-teamcity opened this issue Aug 10, 2018 · 2 comments · Fixed by #28489
Closed

roachtest: upgrade/oldVersion=v2.0.0/nodes=5 failed on master #28452

cockroach-teamcity opened this issue Aug 10, 2018 · 2 comments · Fixed by #28489
Assignees
@petermattis
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
2.1

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/131f4b0dcca7bf002464b02c20ddc6b19816175b

Parameters:

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=827161&tab=buildLog

	test.go:494,upgrade.go:141,upgrade.go:267: /home/agent/work/.go/bin/roachprod run teamcity-827161-upgrade-oldversion-v2-0-0-nodes-5:1 -- ./cockroach quit --insecure --host=:{pgport:1}: exit status 1
@cockroach-teamcity cockroach-teamcity added this to the 2.1 milestone Aug 10, 2018
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Aug 10, 2018
@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/9024a9cef2561a8af0446e31be22488396f45ad3

Parameters:

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=829042&tab=buildLog

@petermattis petermattis assigned petermattis and unassigned tbg Aug 11, 2018
@petermattis
Copy link
Collaborator

Same failure as #28453 and #28454 and requires the same fix: use --port instead of --host in order to be compatible with 2.0 binaries.

@petermattis petermattis mentioned this issue Aug 11, 2018
Merged
petermattis added a commit to petermattis/cockroach that referenced this issue Aug 11, 2018
@petermattis
roachtest: fix upgrade test
defb8cc 
This is the same fix as cockroachdb#28472, but for a different test. Use a `quit`
command line that is compatible with 2.0. This was accidentally broken
in cockroachdb#28373.

Fixes cockroachdb#28452

Release note: None
craig bot pushed a commit that referenced this issue Aug 11, 2018
@petermattis
Merge #28489
49d34b1 
28489: roachtest: fix upgrade test r=tschottdorf a=petermattis

This is the same fix as #28472, but for a different test. Use a `quit`
command line that is compatible with 2.0. This was accidentally broken
in #28373.

Fixes #28452

Release note: None

Co-authored-by: Peter Mattis <petermattis@gmail.com>
@craig craig bot closed this as completed in #28489 Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

roachtest: fix upgrade test petermattis/cockroach
3 participants
@tbg @petermattis @cockroach-teamcity