storage: Be multipath safe. #2596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next up: integration tests. |
mvollmer
force-pushed
the
multipath-support
branch
from
ea9837c
to
664a448
Compare
mvollmer
force-pushed
the
multipath-support
branch
from
664a448
to
b41b9e9
Compare
For multipath testing.
mvollmer
force-pushed
the
multipath-support
branch
from
218f927
to
c20ad9b
Compare
Done. |
| var mpath_members = [ ]; | ||
| var non_mpath_members = [ ]; | ||
|
|
||
| all_blocks.sort(function (a, b) { return a.DeviceNumber - b.DeviceNumber; }); |
There was a problem hiding this comment.
Why do you use the difference between the device numbers as the sort key? This seems unusual enough to deserve a comment.
There was a problem hiding this comment.
Yes, agreed. This is a common pattern in the storage code. I'll factor it out and document it.
Cockpit doesn't depend on it (yet), but the tests will use it.
Show the whole picture about multipath devices and don't let people mess with improperly configured ones. Fixes cockpit-project#2554
mvollmer
force-pushed
the
multipath-support
branch
from
097e2b6
to
64e7e0f
Compare
mvollmer
force-pushed
the
multipath-support
branch
from
64e7e0f
to
7fb286b
Compare
So that we can document it.
mvollmer
force-pushed
the
multipath-support
branch
from
7fb286b
to
a044bf1
Compare
|
code looks good, need to take this for a spin |
|
trying this out looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the whole picture about multipath devices and don't let people
mess with improperly configured ones.