lib: Support headers with TypeaheadSelect #21183
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mvollmer
force-pushed
the
lib-typeahead-select-groups
branch
2 times, most recently
from
866b34b
to
5f5a440
Compare
cockpituous
reviewed
Oct 29, 2024
| onSelect={(_, value) => { | ||
| this.setState({ value }); | ||
| this.onPathChange(value); | ||
| this.props.onChange(value || '', null); |
There was a problem hiding this comment.
This added line is not executed by any test.
| }} | ||
| onClearSelection={this.clearSelection} | ||
| isCreatable={this.props.isOptionCreatable} | ||
| createOptionMessage={val => cockpit.format(_("Create $0"), val)} |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
158
to
159
| const defaultNoOptionsFoundMessage = (filter: string) => `No results found for "${filter}"`; | ||
| const defaultCreateOptionMessage = (newValue: string) => `Create "${newValue}"`; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| // Filter by search term | ||
| const filtered = options.filter((o) => o.header || String(o.content).toLowerCase().includes(filterValue.toLowerCase())) | ||
| // Remove headers that have nothing following them. | ||
| return filtered.filter((o, i) => !(o.header && (i >= filtered.length - 1 || filtered[i + 1].header))); |
There was a problem hiding this comment.
This added line is not executed by any test.
| !newSelectOptions.find((o) => String(o.content).toLowerCase() === filterValue.toLowerCase()) | ||
| ) { | ||
| const createOption = { | ||
| content: typeof createOptionMessage === 'string' ? createOptionMessage : createOptionMessage(filterValue), |
There was a problem hiding this comment.
This added line is not executed by any test.
| isOpen={isOpen} | ||
| selected={selected} | ||
| onSelect={_onSelect} | ||
| onOpenChange={(isOpen) => !isOpen && closeMenu()} |
There was a problem hiding this comment.
This added line is not executed by any test.
pkg/lib/serverTime.js
Outdated
| </Select> | ||
| <TypeaheadSelect toggleProps={ { id: "systime-timezones" } } | ||
| selected={time_zone} | ||
| onSelect={(event, value) => { change("time_zone", value) }} |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+33
to
+34
| onSelect={(_, value) => { | ||
| setValue(value); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
pkg/storaged/dialog.jsx
Outdated
| createOptionMessage={val => cockpit.format(_("Use $0"), val)} | ||
| selected={value} | ||
| onSelect={(_, value) => change(value)} | ||
| onClearSelection={() => change("")} |
There was a problem hiding this comment.
This added line is not executed by any test.
pkg/systemd/logs.jsx
Outdated
| <TypeaheadSelect selectOptions={identifiersArray} | ||
| selected={identifiersFilter} | ||
| onSelect={(e, selection) => { onIdentifiersFilterChange(selection) }} | ||
| onClearSelection={identifiersFilter != "all" && (() => { onIdentifiersFilterChange("all") })} |
There was a problem hiding this comment.
This added line is not executed by any test.
mvollmer
added
the
no-test
mvollmer
force-pushed
the
lib-typeahead-select-groups
branch
2 times, most recently
from
9276ea9
to
a94ee95
Compare
mvollmer
force-pushed
the
lib-typeahead-select-groups
branch
from
a94ee95
to
018531b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have styled the headers arbitrarily like this: