-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Allow Anaconda to override feature detection #21150
base: main
Are you sure you want to change the base?
storage: Allow Anaconda to override feature detection #21150
Conversation
f0ea950
to
09c0e1a
Compare
@M4rtinK, would this be what Anaconda needs? |
09c0e1a
to
94addba
Compare
if (!client.anaconda_feature("btrfs")) { | ||
client.features.btrfs = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 added lines are not executed by any test.
} catch (error) { | ||
console.warn("Can't enable storaged btrfs module", error.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 added lines are not executed by any test.
} catch (error) { | ||
console.warn("Can't enable storaged iscsi module", error.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 added lines are not executed by any test.
if (!client.anaconda_feature("lvm2")) { | ||
client.features.iscsi = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 added lines are not executed by any test.
} catch (error) { | ||
console.warn("Can't enable storaged lvm2 module", error.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 added lines are not executed by any test.
if (!client.anaconda_feature("vdo")) { | ||
client.features.lvm_create_vdo = false; | ||
return Promise.resolve(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 added lines are not executed by any test.
if (!client.anaconda_feature("legacy-vdo")) { | ||
client.features.legacy_vdo = false; | ||
return Promise.resolve(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 added lines are not executed by any test.
const stratis = cockpit.dbus("org.storage.stratis3", { superuser: "try" }); | ||
let stratis_service = "org.storage.stratis3"; | ||
|
||
if (!client.anaconda_feature("stratis")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added line is not executed by any test.
if (!client.anaconda_feature("stratis")) { | ||
// HACK - There is no real clean way to switch off Stratis in | ||
// Cockpit except by making it look for a bogus name... | ||
stratis_service = "does.not.exist"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added line is not executed by any test.
|
||
let val = undefined; | ||
if (client.anaconda.features) | ||
val = client.anaconda.features[tag]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added line is not executed by any test.
See #20844.