Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Allow Anaconda to override feature detection #21150

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Oct 22, 2024

  • tests, coverage

See #20844.

@mvollmer
Copy link
Member Author

@M4rtinK, would this be what Anaconda needs?

@mvollmer mvollmer force-pushed the storage-anaconda-feature-config branch from 09c0e1a to 94addba Compare October 23, 2024 07:05
Comment on lines +862 to +863
if (!client.anaconda_feature("btrfs")) {
client.features.btrfs = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 added lines are not executed by any test.

Comment on lines +872 to +873
} catch (error) {
console.warn("Can't enable storaged btrfs module", error.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 added lines are not executed by any test.

Comment on lines +886 to +887
} catch (error) {
console.warn("Can't enable storaged iscsi module", error.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 added lines are not executed by any test.

Comment on lines +891 to +892
if (!client.anaconda_feature("lvm2")) {
client.features.iscsi = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 added lines are not executed by any test.

Comment on lines +899 to +900
} catch (error) {
console.warn("Can't enable storaged lvm2 module", error.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 added lines are not executed by any test.

Comment on lines +906 to +908
if (!client.anaconda_feature("vdo")) {
client.features.lvm_create_vdo = false;
return Promise.resolve();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 added lines are not executed by any test.

Comment on lines +916 to +918
if (!client.anaconda_feature("legacy-vdo")) {
client.features.legacy_vdo = false;
return Promise.resolve();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 added lines are not executed by any test.

const stratis = cockpit.dbus("org.storage.stratis3", { superuser: "try" });
let stratis_service = "org.storage.stratis3";

if (!client.anaconda_feature("stratis")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added line is not executed by any test.

if (!client.anaconda_feature("stratis")) {
// HACK - There is no real clean way to switch off Stratis in
// Cockpit except by making it look for a bogus name...
stratis_service = "does.not.exist";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added line is not executed by any test.


let val = undefined;
if (client.anaconda.features)
val = client.anaconda.features[tag];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added line is not executed by any test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants