[Locator] Make it better and even more incredible. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobolog
force-pushed
the
kobolog/locator-threads
branch
3 times, most recently
from
d431c91 to
1ae6756
Compare
|
So, the |
kobolog
force-pushed
the
kobolog/locator-threads
branch
2 times, most recently
from
9698978 to
30aacbd
Compare
| template<class Event> | ||
| struct traits { | ||
| struct traits<Event, true> { |
There was a problem hiding this comment.
What's the benefit of weird compilation error on static assert with pretty looking message?
There was a problem hiding this comment.
Static assert error output looks even weirder that this on GCC 4.6.
On Вт, 31 марта 2015 г. at 9:08 Anton Matveenko notifications@github.com
wrote:
In include/cocaine/api/connect.hpp
#182 (comment):template<class Event>
- struct traits {
- struct traits<Event, true> {
What's the benefit of weird compilation error on static assert with pretty
looking message?—
Reply to this email directly or view it on GitHub
https://github.com/cocaine/cocaine-core/pull/182/files#r27476564.
kobolog
force-pushed
the
kobolog/locator-threads
branch
from
30aacbd to
6a85c5f
Compare
This time enforce the rule about disallowing auto method return types for method definitions in source files, when it's not necessary.
kobolog
force-pushed
the
kobolog/locator-threads
branch
from
e642fc8 to
13ac5a8
Compare
kobolog
changed the title
kobolog
pushed a commit
that referenced
this pull request
Apr 1, 2015
[Locator] Make it better and even more incredible.
antmat
pushed a commit
to antmat/cocaine-core
that referenced
this pull request
Jun 19, 2017
3Hren
added a commit
that referenced
this pull request
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make locator thread-safe since the Unicorn Cluster will issue
link_node()anddrop_node()from random ZK client threads, and also drop useless crap.