-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix observe when receiving block2 response #343
Conversation
Pull Request Test Coverage Report for Build 2251396779Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I think we should probably merge #344 first (which addresses some more fundamental observe issues) and see afterwards if this PR is still needed. |
Ok, I release a 1.0.8 with #34 in and then we test again |
Awesome, thank you :) |
921ab61
to
db51224
Compare
Hmm. Not sure if the additional if check changed anything? |
db51224
to
7cc7d6e
Compare
Will merge and release tonight. Sorry for the delay |
* fix: fix observe when receiving block2 response * chore: bump version to 1.0.9
* fix: fix observe when receiving block2 response * chore: bump version to 1.0.9
* fix: fix observe when receiving block2 response * chore: bump version to 1.0.9
This PR incorporates the suggested change by @Thousif-khan and should fix #336.