Fix the private registry logic #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collivier
force-pushed
the
private_registries
branch
from
7e1d1a6 to
611f4b5
Compare
collivier
requested review from
denverwilliams,
HashNuke and
agentpoyo
as code owners
collivier
force-pushed
the
private_registries
branch
3 times, most recently
from
673126b to
bf3b643
Compare
- remove registry:5000 as unused - stop listing registries out the spec tests installing them - cache docker.io everywhere needed - also override registry for private_registry_rolling et al Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
collivier
force-pushed
the
private_registries
branch
from
bf3b643 to
2fcf05b
Compare
collivier
force-pushed
the
private_registries
branch
2 times, most recently
from
86a18a7 to
1e58eaa
Compare
This tests can work without login. Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
A registry is now used to centralize auth. Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
See all failures when running specs (e.g. observability) Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
collivier
force-pushed
the
private_registries
branch
from
1e58eaa to
e92c781
Compare
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested:
Types of changes: