Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configmap: CNF Installation (5.2) Remove installation configmap #2164

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

kosstennbl
Copy link
Collaborator

Description

Installation configmap can significantly complicate new installation
process and has multiple issues with its design (and related tests).
Remove installation congigmap
Redesign related tests or make them always skip until further
redesign would be done in the scope of different change

Issues:

Refs: #2153

@kosstennbl kosstennbl force-pushed the #2153-remove-installation-configmap branch from 9fcd974 to fd7a29d Compare October 8, 2024 08:09
@martin-mat martin-mat self-requested a review October 14, 2024 09:13
@kosstennbl kosstennbl force-pushed the #2153-remove-installation-configmap branch from fd7a29d to db403ad Compare October 14, 2024 14:30
@kosstennbl kosstennbl marked this pull request as draft October 15, 2024 15:17
src/tasks/utils/cnf_manager.cr Outdated Show resolved Hide resolved
src/tasks/utils/cnf_manager.cr Show resolved Hide resolved
src/tasks/utils/cnf_manager.cr Show resolved Hide resolved
src/tasks/utils/cnf_manager.cr Outdated Show resolved Hide resolved
src/tasks/workload/compatibility.cr Outdated Show resolved Hide resolved
src/tasks/workload/microservice.cr Show resolved Hide resolved
src/tasks/workload/microservice.cr Show resolved Hide resolved
src/tasks/workload/microservice.cr Show resolved Hide resolved
src/tasks/workload/microservice.cr Show resolved Hide resolved
src/tasks/workload/microservice.cr Show resolved Hide resolved
@kosstennbl kosstennbl force-pushed the #2153-remove-installation-configmap branch 4 times, most recently from 728ea5e to 0e8f0fe Compare October 24, 2024 07:45
@kosstennbl kosstennbl requested a review from martin-mat October 24, 2024 07:46
spec/workload/installability_spec.cr Outdated Show resolved Hide resolved
spec/5g/ran_spec.cr Show resolved Hide resolved
spec/workload/observability_spec.cr Show resolved Hide resolved
Installation configmap can significantly complicate new installation
process and has multiple issues with its design (and related tests).
Remove installation congigmap
Redesign related tests or make them always skip until further
redesign would be done in the scope of different change

Refs: #2153
Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
@kosstennbl kosstennbl force-pushed the #2153-remove-installation-configmap branch from 0e8f0fe to f872349 Compare October 29, 2024 11:38
@kosstennbl kosstennbl marked this pull request as ready for review October 29, 2024 11:38
Copy link
Collaborator

@svteb svteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martin-mat martin-mat merged commit bf52488 into main Oct 31, 2024
96 of 170 checks passed
@kosstennbl kosstennbl deleted the #2153-remove-installation-configmap branch October 31, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants