-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configmap: CNF Installation (5.2) Remove installation configmap #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstennbl
force-pushed
the
#2153-remove-installation-configmap
branch
from
October 8, 2024 08:09
9fcd974
to
fd7a29d
Compare
kosstennbl
force-pushed
the
#2153-remove-installation-configmap
branch
from
October 14, 2024 14:30
fd7a29d
to
db403ad
Compare
martin-mat
requested changes
Oct 21, 2024
kosstennbl
force-pushed
the
#2153-remove-installation-configmap
branch
4 times, most recently
from
October 24, 2024 07:45
728ea5e
to
0e8f0fe
Compare
svteb
reviewed
Oct 24, 2024
Installation configmap can significantly complicate new installation process and has multiple issues with its design (and related tests). Remove installation congigmap Redesign related tests or make them always skip until further redesign would be done in the scope of different change Refs: #2153 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
kosstennbl
force-pushed
the
#2153-remove-installation-configmap
branch
from
October 29, 2024 11:38
0e8f0fe
to
f872349
Compare
svteb
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
martin-mat
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Smitholi67
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installation configmap can significantly complicate new installation
process and has multiple issues with its design (and related tests).
Remove installation congigmap
Redesign related tests or make them always skip until further
redesign would be done in the scope of different change
Issues:
Refs: #2153