Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microservice Documentation/Helm Deploy/NodePort #205

Merged
merged 12 commits into from
May 12, 2020
Merged

Microservice Documentation/Helm Deploy/NodePort #205

merged 12 commits into from
May 12, 2020

Conversation

denverwilliams
Copy link
Collaborator

@denverwilliams denverwilliams commented May 7, 2020 •
edited by wvwatson
Loading

Microservice Documentation/Helm Deploy/NodePort

Description

Add documentation for new 'microservice' category & tests lfn-cnti/certification#155 lfn-cnti/certification#154
helm_deploy test now available
nodeport_not_used test now available

Issues:

Refs: #155
Refs: #154
Refs: #69
Refs: ##165

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@denverwilliams denverwilliams changed the title Add documentation for new 'microservice' category & tests cncf/cnf-conformance#155 cncf/cnf-conformance#154 Add documentation for new 'microservice' category & tests May 7, 2020
taylor
taylor approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@taylor taylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taylor taylor requested a review from lixuna May 7, 2020 22:17
@taylor taylor added the documentation Improvements or additions to documentation label May 7, 2020
This was linked to issues May 7, 2020
Microservice test: Does the CNF have a reasonable startup time? #154
Closed
Microservice test: Does the CNF have a reasonable container image size? #155
Closed
@nupejosh
Copy link
Collaborator

Also added to PR -
Specs now only take 12 mins
#/issues/69 helm_deploy now has passing tests

@wvwatson wvwatson changed the title Add documentation for new 'microservice' category & tests Microservice Documentation/Helm Deploy/NodePort May 12, 2020
@wvwatson wvwatson merged commit 10683c6 into master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor taylor taylor approved these changes

@lixuna lixuna Awaiting requested review from lixuna

Assignees

@taylor taylor

@wvwatson wvwatson

@denverwilliams denverwilliams

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
5 participants
@denverwilliams @nupejosh @taylor @wvwatson @thewolfpack