Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP v0.6.1-prerelease tests, example CNFs, UX updates #193

Merged
merged 36 commits into from
May 5, 2020

Conversation

taylor
Copy link
Collaborator

@taylor taylor commented May 5, 2020

WIP v0.6.1-prerelease tests, example CNFs, UX updates

Description

Issues:

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

williscool and others added 30 commits April 27, 2020 17:57
refs #cnf-conformance/issues/119
@taylor taylor added enhancement New feature or request wip labels May 5, 2020
@taylor taylor self-assigned this May 5, 2020
@denverwilliams denverwilliams merged commit fda375e into master May 5, 2020
@@ -24,7 +24,11 @@ describe CnfConformance do
it "'all' should run the whole test suite" do
# puts `pwd`
# puts `echo $KUBECONFIG`
response_s = `crystal src/cnf-conformance.cr all verbose`
# Test the binary
build_s = `crystal build src/cnf-conformance.cr`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what builds and tests the binary

@nupejosh
Copy link
Collaborator

nupejosh commented May 5, 2020

👍

@taylor taylor deleted the lastpassing-develop branch May 5, 2020 21:52
@taylor taylor linked an issue May 7, 2020 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add passed + failed messaging with emojis ✔️ + ✖️ prefix for all tests
7 participants