refactor: use egg v4 #747

fengmk2 · 2025-02-04T12:24:08Z

BREAKING CHANGE: only support egg >= 4.0.0

the first app on egg v4

coderabbitai · 2025-02-04T12:24:21Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-02-04T12:24:54Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@eggjs/bin@7.1.0	environment Transitive: eval, filesystem, network, shell, unsafe	`+220`	22.1 MB	fengmk2
npm/@eggjs/mock@6.0.6	environment Transitive: eval, filesystem, network, shell, unsafe	`+188`	17.6 MB	fengmk2
npm/@eggjs/redis@3.0.0	Transitive: environment, eval, filesystem, network, unsafe	`+87`	4.35 MB	fengmk2
npm/@eggjs/scripts@4.0.0	environment Transitive: eval, filesystem, network, shell	`+131`	4.89 MB	fengmk2
npm/@eggjs/tracer@3.0.0	Transitive: environment, eval, filesystem, network, unsafe	`+87`	4.33 MB	fengmk2
npm/egg-typebox-validate-fengmk2@3.0.0-beta.0	Transitive: environment, eval, filesystem, network, unsafe	`+95`	5.81 MB	fengmk2
npm/egg@4.0.9 🔁 npm/egg@3.30.1	Transitive: environment, eval, shell	`+215`	21.6 MB	fengmk2
npm/eslint-config-egg@14.1.0 🔁 npm/eslint-config-egg@13.1.0	Transitive: environment, eval, filesystem, unsafe	`+151`	41.1 MB	fengmk2
npm/typescript@5.8.0-beta 🔁 npm/typescript@5.2.2	None	`0`	22.9 MB	typescript-bot

View full report↗︎

BREAKING CHANGE: only support egg >= 4.0.0 the first app on egg v4 eggjs/egg#3644

codecov · 2025-02-04T13:00:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (2780c53) to head (6a2f648).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   96.33%   96.39%   +0.06%     
==========================================
  Files         191      191              
  Lines       19070    19076       +6     
  Branches     2483     2494      +11     
==========================================
+ Hits        18371    18389      +18     
+ Misses        699      687      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fengmk2 · 2025-02-04T15:19:04Z

tegg 还需要改造一下

typebox 也需要改造 xiekw2010/egg-typebox-validate#3

killagu · 2025-02-05T13:53:58Z

app/port/UserRoleManager.ts

+
+declare module 'egg' {
+  export interface Context {
+    userId?: string;


这里不是很优雅，是不是搞个 User 类然后 inject 比较好。

或者 Context 可以搞成一个 Class，在项目里面可以继承覆盖框架提供的 Context。

import { Context } from 'egg'; class CNPMCoreContext extends Context { userId: string; init() { this.userId = await this.fooService.getUserId(); } }

嗯，可以做 tegg 里面写一个示例文档？

缺少一个 Guards 的抽象实现用户权限判断 https://docs.nestjs.com/guards

fengmk2 added the enhancement New feature or request label Feb 4, 2025

fengmk2 requested review from elrrrrrrr and killagu February 4, 2025 12:24

refactor: use egg v4

3be87fe

BREAKING CHANGE: only support egg >= 4.0.0 the first app on egg v4 eggjs/egg#3644

fengmk2 force-pushed the egg-v4 branch from 7aa829c to 3be87fe Compare February 4, 2025 12:56

f

f8413f5

fengmk2 marked this pull request as draft February 4, 2025 15:19

fengmk2 added 3 commits February 4, 2025 23:20

f

a2ffb84

f

feed980

f

db9dee8

fengmk2 mentioned this pull request Feb 4, 2025

4.0 Milestone eggjs/egg#3644

Open

34 tasks

f

6a2f648

killagu reviewed Feb 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use egg v4 #747

refactor: use egg v4 #747

fengmk2 commented Feb 4, 2025

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

socket-security bot commented Feb 4, 2025 •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading

fengmk2 commented Feb 4, 2025

killagu Feb 5, 2025

killagu Feb 5, 2025

fengmk2 Feb 5, 2025

fengmk2 Feb 6, 2025

refactor: use egg v4 #747

Are you sure you want to change the base?

refactor: use egg v4 #747

Conversation

fengmk2 commented Feb 4, 2025

coderabbitai bot commented Feb 4, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

socket-security bot commented Feb 4, 2025 • edited Loading

codecov bot commented Feb 4, 2025 • edited Loading

Codecov Report

fengmk2 commented Feb 4, 2025

killagu Feb 5, 2025

Choose a reason for hiding this comment

killagu Feb 5, 2025

Choose a reason for hiding this comment

fengmk2 Feb 5, 2025

Choose a reason for hiding this comment

fengmk2 Feb 6, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented Feb 4, 2025 •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading