feat: redis weak #426
Merged
feat: redis weak #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elrrrrrrr
commented
Mar 17, 2023
elrrrrrrr
commented
- 添加 try-catch 防止 redis 请求失败导致读取失败
- 读取完成后异步设置缓存
- Adds try-catch to prevent reading failure from redis interruption.
- Asynchronously sets cache after reading is complete.
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 97.66% 97.48% -0.19%
==========================================
Files 153 153
Lines 13623 13632 +9
Branches 1753 1750 -3
==========================================
- Hits 13305 13289 -16
- Misses 318 343 +25
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fengmk2
pushed a commit
that referenced
this pull request
Mar 20, 2023
[skip ci] ## [3.9.0](v3.8.0...v3.9.0) (2023-03-20) ### Features * redis weak ([#426](#426)) ([300f0e4](300f0e4))
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fengmk2
reviewed
Mar 20, 2023
| @@ -78,7 +85,9 @@ export class ShowPackageController extends AbstractController { | |||
| // only set cache with normal request | |||
| // sync request response with no bug version fixed | |||
| if (!isSync) { | |||
| await this.cacheService.savePackageEtagAndManifests(fullname, isFullManifests, etag, cacheBytes); | |||
| ctx.runInBackground(async () => { | |||
There was a problem hiding this comment.
改成 eventBus 吧，别再使用 runInBackground 了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.